[Webkit-unassigned] [Bug 150002] [iOS] Remove unnecessary iOS version checks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150002

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262829|review?                     |review+
              Flags|                            |

--- Comment #3 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 262829
  --> https://bugs.webkit.org/attachment.cgi?id=262829
Remove redundant version checks

View in context: https://bugs.webkit.org/attachment.cgi?id=262829&action=review

> Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:58
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 1090)

I suggest removing these parentheses.

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1109
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000)

Ditto.

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1407
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000)

Ditto.

> Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm:105
> +#if defined UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP && UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP

I didn't know one could use "defined" without parentheses. I suggest adding them for consistency.

> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:318
> -		1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; settings = {ASSET_TAGS = (); }; };
> -		1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; settings = {ASSET_TAGS = (); }; };
> +		1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; };
> +		1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; };

Is this change intentionally part of this patch?

> Tools/WebKitTestRunner/ios/UIKitSPI.h:-48
> -- (void)_handleHIDEvent:(IOHIDEventRef)event;

Just to confirm, this was removed because it's unneeded, correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151010/d46d779f/attachment.html>