<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Remove unnecessary iOS version checks"
href="https://bugs.webkit.org/show_bug.cgi?id=150002">bug 150002</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262829 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Remove unnecessary iOS version checks"
href="https://bugs.webkit.org/show_bug.cgi?id=150002#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [iOS] Remove unnecessary iOS version checks"
href="https://bugs.webkit.org/show_bug.cgi?id=150002">bug 150002</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262829&action=diff" name="attach_262829" title="Remove redundant version checks">attachment 262829</a> <a href="attachment.cgi?id=262829&action=edit" title="Remove redundant version checks">[details]</a></span>
Remove redundant version checks
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262829&action=review">https://bugs.webkit.org/attachment.cgi?id=262829&action=review</a>
<span class="quote">> Source/WebCore/loader/cocoa/DiskCacheMonitorCocoa.h:58
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 1090)</span >
I suggest removing these parentheses.
<span class="quote">> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1109
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000)</span >
Ditto.
<span class="quote">> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1407
> +#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000)</span >
Ditto.
<span class="quote">> Source/WebKit2/Shared/ios/NativeWebTouchEventIOS.mm:105
> +#if defined UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP && UI_WEB_TOUCH_EVENT_HAS_IS_POTENTIAL_TAP</span >
I didn't know one could use "defined" without parentheses. I suggest adding them for consistency.
<span class="quote">> Source/WebKit2/WebKit2.xcodeproj/project.pbxproj:318
> - 1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; settings = {ASSET_TAGS = (); }; };
> - 1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; settings = {ASSET_TAGS = (); }; };
> + 1A8B66B01BC43C860082DF77 /* PageLoadStateObserver.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A8B66AE1BC43C860082DF77 /* PageLoadStateObserver.h */; };
> + 1A8B66B31BC45B010082DF77 /* WKBundleMac.mm in Sources */ = {isa = PBXBuildFile; fileRef = 1A8B66B11BC45B010082DF77 /* WKBundleMac.mm */; };</span >
Is this change intentionally part of this patch?
<span class="quote">> Tools/WebKitTestRunner/ios/UIKitSPI.h:-48
> -- (void)_handleHIDEvent:(IOHIDEventRef)event;</span >
Just to confirm, this was removed because it's unneeded, correct?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>