[Webkit-unassigned] [Bug 149843] Backgrounds bleed out of natively rendered text fields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149843

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262705|review?                     |review+
              Flags|                            |

--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 262705
  --> https://bugs.webkit.org/attachment.cgi?id=262705
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262705&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:856
> +    FloatRect adjustedPaintRect(r);

I think this needs a brief, precise comment explaining why the code does this. The sequence starting on this line is a perfect example of code that is not self explanatory! Maybe something like the change log, but shorter.

> Source/WebCore/rendering/RenderThemeMac.mm:860
> +        adjustedPaintRect.inflateX(LayoutUnit::fromPixel(1) / transform.xScale());
> +        adjustedPaintRect.inflateY(LayoutUnit::fromPixel(1) / transform.yScale());

Does this yield a different result than if you write:

    adjustedPaintRect.inflateX(1 / transform.xScale());
    adjustedPaintRect.inflateY(1 / transform.xScale());

I’m not sure why it’s helpful to involve LayoutUnit since xScale and yScale are already floating point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151008/5de7cc7f/attachment.html>