<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Backgrounds bleed out of natively rendered text fields"
href="https://bugs.webkit.org/show_bug.cgi?id=149843">bug 149843</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262705 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Backgrounds bleed out of natively rendered text fields"
href="https://bugs.webkit.org/show_bug.cgi?id=149843#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Backgrounds bleed out of natively rendered text fields"
href="https://bugs.webkit.org/show_bug.cgi?id=149843">bug 149843</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262705&action=diff" name="attach_262705" title="Patch">attachment 262705</a> <a href="attachment.cgi?id=262705&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262705&action=review">https://bugs.webkit.org/attachment.cgi?id=262705&action=review</a>
<span class="quote">> Source/WebCore/rendering/RenderThemeMac.mm:856
> + FloatRect adjustedPaintRect(r);</span >
I think this needs a brief, precise comment explaining why the code does this. The sequence starting on this line is a perfect example of code that is not self explanatory! Maybe something like the change log, but shorter.
<span class="quote">> Source/WebCore/rendering/RenderThemeMac.mm:860
> + adjustedPaintRect.inflateX(LayoutUnit::fromPixel(1) / transform.xScale());
> + adjustedPaintRect.inflateY(LayoutUnit::fromPixel(1) / transform.yScale());</span >
Does this yield a different result than if you write:
adjustedPaintRect.inflateX(1 / transform.xScale());
adjustedPaintRect.inflateY(1 / transform.xScale());
I’m not sure why it’s helpful to involve LayoutUnit since xScale and yScale are already floating point.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>