[Webkit-unassigned] [Bug 149807] [Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149807

Benjamin Poulain <benjamin at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #262439|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Benjamin Poulain <benjamin at webkit.org> ---
Comment on attachment 262439
  --> https://bugs.webkit.org/attachment.cgi?id=262439
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=262439&action=review

Ok

> Source/JavaScriptCore/runtime/IntlCollatorConstructor.cpp:152
> +    const Vector<String>& requestedLocales = canonicalizeLocaleList(exec, exec->argument(0));

IMHO, using Vector<String> makes the lifetime clearer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151005/e2236ab0/attachment.html>