<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:benjamin@webkit.org" title="Benjamin Poulain <benjamin@webkit.org>"> <span class="fn">Benjamin Poulain</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>"
href="https://bugs.webkit.org/show_bug.cgi?id=149807">bug 149807</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #262439 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>"
href="https://bugs.webkit.org/show_bug.cgi?id=149807#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [Intl] Change the return type of canonicalizeLocaleList() from JSArray* to Vector<String>"
href="https://bugs.webkit.org/show_bug.cgi?id=149807">bug 149807</a>
from <span class="vcard"><a class="email" href="mailto:benjamin@webkit.org" title="Benjamin Poulain <benjamin@webkit.org>"> <span class="fn">Benjamin Poulain</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=262439&action=diff" name="attach_262439" title="Patch">attachment 262439</a> <a href="attachment.cgi?id=262439&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=262439&action=review">https://bugs.webkit.org/attachment.cgi?id=262439&action=review</a>
Ok
<span class="quote">> Source/JavaScriptCore/runtime/IntlCollatorConstructor.cpp:152
> + const Vector<String>& requestedLocales = canonicalizeLocaleList(exec, exec->argument(0));</span >
IMHO, using Vector<String> makes the lifetime clearer.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>