[Webkit-unassigned] [Bug 151513] REGRESSION(r192247): [GTK] ASSERTION FAILED: type == WebCore::ActionType || type == WebCore::CheckableActionType || type == WebCore::SeparatorType

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151513

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 266243
  --> https://bugs.webkit.org/attachment.cgi?id=266243
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=266243&action=review

> Source/WebKit2/ChangeLog:15
> +        WebContextMenuItemGtk is SubmenuType if it has submenu itmes, but

itmes -> items

> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:128
> +    : WebContextMenuItemData(data.type() == SubmenuType ? ActionType : data.type(), data.action(), data.title(), data.enabled(), data.checked())

I think you should add this check to the constructor above, as well...

> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.cpp:212
> +    item->priv->menuItem = std::make_unique<WebContextMenuItemGtk>(ActionType, ContextMenuItemBaseApplicationTag, String::fromUTF8(label));

...so that you don't need to do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151130/d33042e0/attachment.html>