<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192247): [GTK] ASSERTION FAILED: type == WebCore::ActionType || type == WebCore::CheckableActionType || type == WebCore::SeparatorType"
href="https://bugs.webkit.org/show_bug.cgi?id=151513#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192247): [GTK] ASSERTION FAILED: type == WebCore::ActionType || type == WebCore::CheckableActionType || type == WebCore::SeparatorType"
href="https://bugs.webkit.org/show_bug.cgi?id=151513">bug 151513</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=266243&action=diff" name="attach_266243" title="Patch">attachment 266243</a> <a href="attachment.cgi?id=266243&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=266243&action=review">https://bugs.webkit.org/attachment.cgi?id=266243&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:15
> + WebContextMenuItemGtk is SubmenuType if it has submenu itmes, but</span >
itmes -> items
<span class="quote">> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:128
> + : WebContextMenuItemData(data.type() == SubmenuType ? ActionType : data.type(), data.action(), data.title(), data.enabled(), data.checked())</span >
I think you should add this check to the constructor above, as well...
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitContextMenuItem.cpp:212
> + item->priv->menuItem = std::make_unique<WebContextMenuItemGtk>(ActionType, ContextMenuItemBaseApplicationTag, String::fromUTF8(label));</span >
...so that you don't need to do this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>