[Webkit-unassigned] [Bug 125868] Crash when trying to copy image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=125868

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #260269|review?                     |review+
              Flags|                            |

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 260269
  --> https://bugs.webkit.org/attachment.cgi?id=260269
Patch to reduce memory usage and CPU time with test.

View in context: https://bugs.webkit.org/attachment.cgi?id=260269&action=review

Looks good.

> Source/WebCore/platform/mac/PasteboardMac.mm:258
> +    NSData *imageData = (NSData*)(pasteboardImage.image->getTIFFRepresentation());

We should not use NSData here at all. Instead:

    CFDataRef imageData = pasteboardImage.image->getTIFFRepresentation();

And then below change SharedBuffer::wrapNSData to SharedBuffer::wrapCFData.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151130/98d0d31a/attachment.html>