<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when trying to copy image"
href="https://bugs.webkit.org/show_bug.cgi?id=125868">bug 125868</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #260269 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when trying to copy image"
href="https://bugs.webkit.org/show_bug.cgi?id=125868#c7">Comment # 7</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Crash when trying to copy image"
href="https://bugs.webkit.org/show_bug.cgi?id=125868">bug 125868</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=260269&action=diff" name="attach_260269" title="Patch to reduce memory usage and CPU time with test.">attachment 260269</a> <a href="attachment.cgi?id=260269&action=edit" title="Patch to reduce memory usage and CPU time with test.">[details]</a></span>
Patch to reduce memory usage and CPU time with test.
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=260269&action=review">https://bugs.webkit.org/attachment.cgi?id=260269&action=review</a>
Looks good.
<span class="quote">> Source/WebCore/platform/mac/PasteboardMac.mm:258
> + NSData *imageData = (NSData*)(pasteboardImage.image->getTIFFRepresentation());</span >
We should not use NSData here at all. Instead:
CFDataRef imageData = pasteboardImage.image->getTIFFRepresentation();
And then below change SharedBuffer::wrapNSData to SharedBuffer::wrapCFData.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>