[Webkit-unassigned] [Bug 151391] [GLIB] Implement garbage collector timers

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 23 01:38:56 PST 2015


--- Comment #13 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 265749
  --> https://bugs.webkit.org/attachment.cgi?id=265749

View in context: https://bugs.webkit.org/attachment.cgi?id=265749&action=review

>> Source/JavaScriptCore/heap/HeapTimer.cpp:171
>> +        static_cast<HeapTimer*>(userData)->timerDidFire();
> What do you think of just writing out ::timerDidFire() in this lambda?

We can't capture this in a lambda wrapping a c function pointer.

>> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:75
>> +    g_source_set_ready_time(m_timer.get(), g_get_monotonic_time() + (sweepTimeSlice * sweepTimeMultiplier));
> You're adding 0.1 seconds to g_get_monotonic_time(), which returns microseconds.

Good catch!

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151123/a0895cfb/attachment.html>

More information about the webkit-unassigned mailing list