<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement garbage collector timers"
href="https://bugs.webkit.org/show_bug.cgi?id=151391#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement garbage collector timers"
href="https://bugs.webkit.org/show_bug.cgi?id=151391">bug 151391</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265749&action=diff" name="attach_265749" title="Patch">attachment 265749</a> <a href="attachment.cgi?id=265749&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265749&action=review">https://bugs.webkit.org/attachment.cgi?id=265749&action=review</a>
<span class="quote">>> Source/JavaScriptCore/heap/HeapTimer.cpp:171
>> + static_cast<HeapTimer*>(userData)->timerDidFire();
>
> What do you think of just writing out ::timerDidFire() in this lambda?</span >
We can't capture this in a lambda wrapping a c function pointer.
<span class="quote">>> Source/JavaScriptCore/heap/IncrementalSweeper.cpp:75
>> + g_source_set_ready_time(m_timer.get(), g_get_monotonic_time() + (sweepTimeSlice * sweepTimeMultiplier));
>
> You're adding 0.1 seconds to g_get_monotonic_time(), which returns microseconds.</span >
Good catch!</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>