[Webkit-unassigned] [Bug 151261] [GTK] ImageDiff should normalize the diff image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151261

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265855|review?                     |review+
              Flags|                            |

--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 265855
  --> https://bugs.webkit.org/attachment.cgi?id=265855
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265855&action=review

Can't we immediately unskip a bunch of tests?

> Tools/ImageDiff/gtk/ImageDiff.cpp:85
> +                bufferPixel /= maxDistance;

What guarantees that maxDistance is not 0?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151120/f1a9150d/attachment.html>