[Webkit-unassigned] [Bug 151261] [GTK] ImageDiff should normalize the diff image

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151261

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 265855 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265855&action=review
> 
> Can't we immediately unskip a bunch of tests?

No, this doesn't fix any test, this only makes it easier to see the differences when they are minimum, see the examples Carlos posted here, without the patch you see a diff that looks completely black, while after the patch you easily see the pixel that is different. 

> > Tools/ImageDiff/gtk/ImageDiff.cpp:85
> > +                bufferPixel /= maxDistance;
> 
> What guarantees that maxDistance is not 0?

I think differenceImageFromDifferenceBuffer wouldn't be called in that case, I could ensure it just in case

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151120/9bcdda3c/attachment-0001.html>