[Webkit-unassigned] [Bug 151239] This is why I love or hate the commit queue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 20 03:00:41 PST 2015


--- Comment #17 from Csaba Osztrogonác <ossy at webkit.org> ---
(In reply to comment #16)
> https://bugs.webkit.org/show_bug.cgi?id=151418 finally passed the commit
> queue, but broke the GTK build and broke API tests.

CQ can break the build, because folks want this behaviour:
- https://lists.webkit.org/pipermail/webkit-dev/2014-January/026068.html
- https://bugs.webkit.org/show_bug.cgi?id=127079

I don't agree with this, but I have only one vote. :(

Previously a build failure (red EWS bubble) set cq- flag immediately
to avoid breaking builds. But it didn't help if an eager reviewer
set r+/cq+ immediately after the patch is uploaded, leaving no
chance to the EWS bot to run. I remember, it happened many times.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151120/97b2a3a5/attachment-0001.html>

More information about the webkit-unassigned mailing list