<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - This is why I love or hate the commit queue"
href="https://bugs.webkit.org/show_bug.cgi?id=151239#c17">Comment # 17</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - This is why I love or hate the commit queue"
href="https://bugs.webkit.org/show_bug.cgi?id=151239">bug 151239</a>
from <span class="vcard"><a class="email" href="mailto:ossy@webkit.org" title="Csaba Osztrogonác <ossy@webkit.org>"> <span class="fn">Csaba Osztrogonác</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151239#c16">comment #16</a>)
<span class="quote">> <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Remove the non-NetworkProcess configurations"
href="show_bug.cgi?id=151418">https://bugs.webkit.org/show_bug.cgi?id=151418</a> finally passed the commit
> queue, but broke the GTK build and broke API tests.</span >
CQ can break the build, because folks want this behaviour:
- <a href="https://lists.webkit.org/pipermail/webkit-dev/2014-January/026068.html">https://lists.webkit.org/pipermail/webkit-dev/2014-January/026068.html</a>
- <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - EWS shouldn't comment on Bugzilla for failing builds or style errors"
href="show_bug.cgi?id=127079">https://bugs.webkit.org/show_bug.cgi?id=127079</a>
I don't agree with this, but I have only one vote. :(
Previously a build failure (red EWS bubble) set cq- flag immediately
to avoid breaking builds. But it didn't help if an eager reviewer
set r+/cq+ immediately after the patch is uploaded, leaving no
chance to the EWS bot to run. I remember, it happened many times.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>