[Webkit-unassigned] [Bug 151391] [GLIB] Implement garbage collector timers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151391

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 265749 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=265749&action=review
> 
> Great work! I noticed this was missing yesterday too, so I'm very happy that
> you fixed it. I just have a couple quick questions before I feel comfortable
> giving an r+...
> 
> > Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:33
> > -#if USE(CF) || PLATFORM(EFL)
> > +#if USE(CF) || USE(GLIB)
> 
> Is USE(GLIB) also true for EFL? I wonder if it wouldn't be better to be more
> explicit here for the sake of code readability and leave this as:

Yes, it's true.

> #if USE(CF) || PLATFORM(EFL) || USE(GLIB)

Looks redundant to me, the fewer || the better IMO.

> > Source/JavaScriptCore/heap/HeapTimer.cpp:155
> > +        if (g_source_get_ready_time(source) == -1)
> > +            return G_SOURCE_CONTINUE;
> 
> In what circumstances can this happen?

If the timer is cancelled in a different thread right before being dispatched by the main context.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151119/c8f2fb49/attachment-0001.html>