<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement garbage collector timers"
href="https://bugs.webkit.org/show_bug.cgi?id=151391#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Implement garbage collector timers"
href="https://bugs.webkit.org/show_bug.cgi?id=151391">bug 151391</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151391#c2">comment #2</a>)
<span class="quote">> Comment on <span class=""><a href="attachment.cgi?id=265749&action=diff" name="attach_265749" title="Patch">attachment 265749</a> <a href="attachment.cgi?id=265749&action=edit" title="Patch">[details]</a></span>
> Patch
>
> View in context:
> <a href="https://bugs.webkit.org/attachment.cgi?id=265749&action=review">https://bugs.webkit.org/attachment.cgi?id=265749&action=review</a>
>
> Great work! I noticed this was missing yesterday too, so I'm very happy that
> you fixed it. I just have a couple quick questions before I feel comfortable
> giving an r+...
>
> > Source/JavaScriptCore/heap/EdenGCActivityCallback.cpp:33
> > -#if USE(CF) || PLATFORM(EFL)
> > +#if USE(CF) || USE(GLIB)
>
> Is USE(GLIB) also true for EFL? I wonder if it wouldn't be better to be more
> explicit here for the sake of code readability and leave this as:</span >
Yes, it's true.
<span class="quote">> #if USE(CF) || PLATFORM(EFL) || USE(GLIB)</span >
Looks redundant to me, the fewer || the better IMO.
<span class="quote">> > Source/JavaScriptCore/heap/HeapTimer.cpp:155
> > + if (g_source_get_ready_time(source) == -1)
> > + return G_SOURCE_CONTINUE;
>
> In what circumstances can this happen?</span >
If the timer is cancelled in a different thread right before being dispatched by the main context.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>