[Webkit-unassigned] [Bug 151398] Web Inspector: when testing frontend, inserting external resource in DOM crashes WebKit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 14:25:52 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=151398

--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
This is happening because the FrameLoaderClient clears the request:

    void ResourceLoadNotifier::dispatchWillSendRequest(DocumentLoader* loader, unsigned long identifier, ResourceRequest& request, const ResourceResponse& redirectResponse)
    {
        ...
        String oldRequestURL = request.url().string();
        m_frame.loader().documentLoader()->didTellClientAboutLoad(request.url());

        m_frame.loader().client().dispatchWillSendRequest(loader, identifier, request, redirectResponse);

        // If the URL changed, then we want to put that new URL in the "did tell client" set too.
        if (!request.isNull() && oldRequestURL != request.url().string())
            m_frame.loader().documentLoader()->didTellClientAboutLoad(request.url());

        InspectorInstrumentation::willSendRequest(&m_frame, identifier, loader, request, redirectResponse);
        ...
    }

In this case, the inspector code and below does not gracefully handle a null string.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/8c38849c/attachment.html>


More information about the webkit-unassigned mailing list