[Webkit-unassigned] [Bug 151398] Web Inspector: when testing frontend, inserting external resource in DOM crashes WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=151398

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |achristensen at apple.com,
                   |                            |beidson at apple.com

--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Higher up in the stack, it looks like the inspector is told about a resource request which is basically empty:

(lldb) f
frame #13: 0x0000000112e57812 WebCore`WebCore::ResourceLoadNotifier::dispatchWillSendRequest(this=0x0000000119aea0c0, loader=0x000000011983a000, identifier=3, request=0x00007fff5af4e400, redirectResponse=0x00007fff5af4e528) + 338 at ResourceLoadNotifier.cpp:139
   136         if (!request.isNull() && oldRequestURL != request.url().string())
   137             m_frame.loader().documentLoader()->didTellClientAboutLoad(request.url());
   138     
-> 139         InspectorInstrumentation::willSendRequest(&m_frame, identifier, loader, request, redirectResponse);
   140     
   141         // Report WebTiming for all frames.
   142         if (loader && !request.isNull() && request.url() == loader->url())

(lldb) p request.isNull()
(bool) $12 = true

So perhaps we shouldn't be telling the inspector about null requests.

Why would we even get here... I'll ping some loader folks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/bfbf1d7d/attachment.html>