[Webkit-unassigned] [Bug 149338] [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=149338

--- Comment #115 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 265735
  --> https://bugs.webkit.org/attachment.cgi?id=265735
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265735&action=review

Some drive by style comments.

> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1884
> +    

Whitespace!

> Source/JavaScriptCore/runtime/CommonIdentifiers.h:333
> +    macro(newTargetLocal)\
> +    macro(derivedConstructor)\

Style: Seems the normal style is to have a space after the macro.

> Source/JavaScriptCore/runtime/Executable.h:398
> +    ScriptExecutable(Structure*, VM&, const SourceCode&, bool, bool, bool);

These bools are rather mysterious. When it is non-obvious the header should normally include the name. If someone only had the header they should understand what these bools mean!

> Source/JavaScriptCore/runtime/JSGlobalObject.h:664
> +    UnlinkedEvalCodeBlock* createEvalCodeBlock(CallFrame*, EvalExecutable*, ThisTDZMode, bool, const VariableEnvironment*);

Same, this bool should really have a name.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151118/d003e241/attachment.html>