<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338#c115">Comment # 115</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment"
href="https://bugs.webkit.org/show_bug.cgi?id=149338">bug 149338</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265735&action=diff" name="attach_265735" title="Patch">attachment 265735</a> <a href="attachment.cgi?id=265735&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265735&action=review">https://bugs.webkit.org/attachment.cgi?id=265735&action=review</a>
Some drive by style comments.
<span class="quote">> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1884
> + </span >
Whitespace!
<span class="quote">> Source/JavaScriptCore/runtime/CommonIdentifiers.h:333
> + macro(newTargetLocal)\
> + macro(derivedConstructor)\</span >
Style: Seems the normal style is to have a space after the macro.
<span class="quote">> Source/JavaScriptCore/runtime/Executable.h:398
> + ScriptExecutable(Structure*, VM&, const SourceCode&, bool, bool, bool);</span >
These bools are rather mysterious. When it is non-obvious the header should normally include the name. If someone only had the header they should understand what these bools mean!
<span class="quote">> Source/JavaScriptCore/runtime/JSGlobalObject.h:664
> + UnlinkedEvalCodeBlock* createEvalCodeBlock(CallFrame*, EvalExecutable*, ThisTDZMode, bool, const VariableEnvironment*);</span >
Same, this bool should really have a name.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>