[Webkit-unassigned] [Bug 151324] REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 10:25:09 PST 2015


Brian Burg <bburg at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |bburg at apple.com

--- Comment #5 from Brian Burg <bburg at apple.com> ---
(In reply to comment #4)
> Created attachment 265679 [details]
> Speed up AssignmentPattern parsing
> I haven't run the full test suite, this isn't ready yet, but it does produce
> a significant speedup for loading this page. Most real-world destructuring
> patterns are probably not that big, so while those would still be slow, they
> shouldn't be as noticeable.

This seems like a good choice. You should add a similar test case to Joe's as a regression test. 

> PS, webkit-patch is failing to upload my patches today
> (https://gist.github.com/caitp/27af5c48cd1758c65784 for a log), so this is
> just the output from `git format-patch`, hope that's cool.

We've been having server issues. As long as the patch applies, it doesn't matter how it's generated. Without webkit-patch, you will need to manually set flags for r?, cq?, and submitting it to EWS by clicking the button next to the attachment.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151117/da3fb1d5/attachment-0001.html>

More information about the webkit-unassigned mailing list