<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression"
href="https://bugs.webkit.org/show_bug.cgi?id=151324">bug 151324</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>bburg@apple.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression"
href="https://bugs.webkit.org/show_bug.cgi?id=151324#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - REGRESSION(r192436): Inspector Hanging under tryParseDestructuringPatternExpression"
href="https://bugs.webkit.org/show_bug.cgi?id=151324">bug 151324</a>
from <span class="vcard"><a class="email" href="mailto:bburg@apple.com" title="Brian Burg <bburg@apple.com>"> <span class="fn">Brian Burg</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=151324#c4">comment #4</a>)
<span class="quote">> Created <span class=""><a href="attachment.cgi?id=265679&action=diff" name="attach_265679" title="Speed up AssignmentPattern parsing">attachment 265679</a> <a href="attachment.cgi?id=265679&action=edit" title="Speed up AssignmentPattern parsing">[details]</a></span>
> Speed up AssignmentPattern parsing
>
> I haven't run the full test suite, this isn't ready yet, but it does produce
> a significant speedup for loading this page. Most real-world destructuring
> patterns are probably not that big, so while those would still be slow, they
> shouldn't be as noticeable.</span >
This seems like a good choice. You should add a similar test case to Joe's as a regression test.
<span class="quote">> PS, webkit-patch is failing to upload my patches today
> (<a href="https://gist.github.com/caitp/27af5c48cd1758c65784">https://gist.github.com/caitp/27af5c48cd1758c65784</a> for a log), so this is
> just the output from `git format-patch`, hope that's cool.</span >
We've been having server issues. As long as the patch applies, it doesn't matter how it's generated. Without webkit-patch, you will need to manually set flags for r?, cq?, and submitting it to EWS by clicking the button next to the attachment.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>