[Webkit-unassigned] [Bug 150987] Web Inspector: Dashboard weight/size should show transferred size not total resources size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150987

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #265442|review?                     |review-
              Flags|                            |

--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 265442
  --> https://bugs.webkit.org/attachment.cgi?id=265442
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=265442&action=review

Looks good. As mentioned on IRC, I'd like to see some tests for WebInspector.Resource.size/transferSize. Like, do we handle transferSize of dataURLs correctly as 0 for non-main resources?

> Source/WebInspectorUI/ChangeLog:9
> +        show transferred size on Dashboard weight
> +        show resources size on Dashboard weight tooltip

Nit: Use full sentences starting with a capital and ending with a period. This is meant to be a paragraph describing the patch.

> Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:154
> +        if (!event.target.mainResource.cached && event.target.mainResource.size)
> +            this.transferredSize = event.target.mainResource.size;

Why are we resorting to using event.target.mainResource.size here instead of mainResource's transferSize? Are we running into an issue where the main resource's transfer size is not correct?

r- until we get an answer to this question!

> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:93
> +
> +        } else {
> +            sizeItem.text = "\u2014";
> +        }

Style: No need for the blank line.
Style: No braces for single statement if/else, so remove the braces for the else block.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151113/a1b15bab/attachment.html>