<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Dashboard weight/size should show transferred size not total resources size"
href="https://bugs.webkit.org/show_bug.cgi?id=150987">bug 150987</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #265442 Flags</td>
<td>review?
</td>
<td>review-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Dashboard weight/size should show transferred size not total resources size"
href="https://bugs.webkit.org/show_bug.cgi?id=150987#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Web Inspector: Dashboard weight/size should show transferred size not total resources size"
href="https://bugs.webkit.org/show_bug.cgi?id=150987">bug 150987</a>
from <span class="vcard"><a class="email" href="mailto:joepeck@webkit.org" title="Joseph Pecoraro <joepeck@webkit.org>"> <span class="fn">Joseph Pecoraro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=265442&action=diff" name="attach_265442" title="patch">attachment 265442</a> <a href="attachment.cgi?id=265442&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=265442&action=review">https://bugs.webkit.org/attachment.cgi?id=265442&action=review</a>
Looks good. As mentioned on IRC, I'd like to see some tests for WebInspector.Resource.size/transferSize. Like, do we handle transferSize of dataURLs correctly as 0 for non-main resources?
<span class="quote">> Source/WebInspectorUI/ChangeLog:9
> + show transferred size on Dashboard weight
> + show resources size on Dashboard weight tooltip</span >
Nit: Use full sentences starting with a capital and ending with a period. This is meant to be a paragraph describing the patch.
<span class="quote">> Source/WebInspectorUI/UserInterface/Models/DefaultDashboard.js:154
> + if (!event.target.mainResource.cached && event.target.mainResource.size)
> + this.transferredSize = event.target.mainResource.size;</span >
Why are we resorting to using event.target.mainResource.size here instead of mainResource's transferSize? Are we running into an issue where the main resource's transfer size is not correct?
r- until we get an answer to this question!
<span class="quote">> Source/WebInspectorUI/UserInterface/Views/DefaultDashboardView.js:93
> +
> + } else {
> + sizeItem.text = "\u2014";
> + }</span >
Style: No need for the blank line.
Style: No braces for single statement if/else, so remove the braces for the else block.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>