[Webkit-unassigned] [Bug 144560] [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144560

--- Comment #38 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #37)
> (In reply to comment #36)
> > Comment on attachment 264506 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=264506&action=review
> > 
> > > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:47
> > > -#ifdef SOCK_SEQPACKET
> > > +#if defined(SOCK_SEQPACKET) && !PLATFORM(GTK)
> > >  #define SOCKET_TYPE SOCK_SEQPACKET
> > 
> > This is wrong, we always want to use SOCK_SEQPACKET if available, why did
> > you add !PLATFORM(GTK) ?
> 
> It's been such a long time since I first wrote this, I don't have my notes
> anymore on the error message that SOCK_SEQPACKET caused. I can try to
> compile again without this change and see what the problem was.

This is disabling SOCK_SEQPACKET for GTK port in all platforms, not only mac. I'm sure it doesn't break the build in linux, since we have always used it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151110/0011cbab/attachment.html>