<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560#c38">Comment # 38</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - [GTK] Fix combinations of PLATFORM(GTK) and OS(DARWIN)"
href="https://bugs.webkit.org/show_bug.cgi?id=144560">bug 144560</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=144560#c37">comment #37</a>)
<span class="quote">> (In reply to <a href="show_bug.cgi?id=144560#c36">comment #36</a>)
> > Comment on <span class=""><a href="attachment.cgi?id=264506&action=diff" name="attach_264506" title="Patch">attachment 264506</a> <a href="attachment.cgi?id=264506&action=edit" title="Patch">[details]</a></span>
> > Patch
> >
> > View in context:
> > <a href="https://bugs.webkit.org/attachment.cgi?id=264506&action=review">https://bugs.webkit.org/attachment.cgi?id=264506&action=review</a>
> >
> > > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:47
> > > -#ifdef SOCK_SEQPACKET
> > > +#if defined(SOCK_SEQPACKET) && !PLATFORM(GTK)
> > > #define SOCKET_TYPE SOCK_SEQPACKET
> >
> > This is wrong, we always want to use SOCK_SEQPACKET if available, why did
> > you add !PLATFORM(GTK) ?
>
> It's been such a long time since I first wrote this, I don't have my notes
> anymore on the error message that SOCK_SEQPACKET caused. I can try to
> compile again without this change and see what the problem was.</span >
This is disabling SOCK_SEQPACKET for GTK port in all platforms, not only mac. I'm sure it doesn't break the build in linux, since we have always used it.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>