[Webkit-unassigned] [Bug 150859] run-webkit-test should look in --root directory for LayoutTestRelay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 14:44:06 PST 2015


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #264882|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #14 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 264882
  --> https://bugs.webkit.org/attachment.cgi?id=264882

View in context: https://bugs.webkit.org/attachment.cgi?id=264882&action=review

> Tools/Scripts/webkitpy/port/base.py:1145
> +            # We take advantage of the options being passed to workers as a way to precompute the root
> +            # directory path to pass to subprocesses and avoid making the slow call to config.build_directory()
> +            # N times in each worker.

Maybe a better way to write this would be:

We take advantage of the behavior that self._options is passed by reference to worker subprocesses to use it as data store to cache the computed root directory path. This avoids making each worker subprocess compute this path again which is slow because of the call to config.build_directory().

> Tools/Scripts/webkitpy/port/base.py:1150
> +            self.set_option_default('_cached_root', root_directory)

Can we use self.set_option() here instead of self.set_option_default()?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151105/4098fdee/attachment.html>

More information about the webkit-unassigned mailing list