<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span> changed
<a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859">bug 150859</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #264882 Flags</td>
<td>review?, commit-queue?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859#c14">Comment # 14</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859">bug 150859</a>
from <span class="vcard"><a class="email" href="mailto:dbates@webkit.org" title="Daniel Bates <dbates@webkit.org>"> <span class="fn">Daniel Bates</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264882&action=diff" name="attach_264882" title="Patch">attachment 264882</a> <a href="attachment.cgi?id=264882&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264882&action=review">https://bugs.webkit.org/attachment.cgi?id=264882&action=review</a>
<span class="quote">> Tools/Scripts/webkitpy/port/base.py:1145
> + # We take advantage of the options being passed to workers as a way to precompute the root
> + # directory path to pass to subprocesses and avoid making the slow call to config.build_directory()
> + # N times in each worker.</span >
Maybe a better way to write this would be:
We take advantage of the behavior that self._options is passed by reference to worker subprocesses to use it as data store to cache the computed root directory path. This avoids making each worker subprocess compute this path again which is slow because of the call to config.build_directory().
<span class="quote">> Tools/Scripts/webkitpy/port/base.py:1150
> + self.set_option_default('_cached_root', root_directory)</span >
Can we use self.set_option() here instead of self.set_option_default()?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>