[Webkit-unassigned] [Bug 150859] run-webkit-test should look in --root directory for LayoutTestRelay

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 5 11:09:23 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=150859

--- Comment #12 from Jason Marcell <jmarcell at apple.com> ---
The property `_root_was_set` gets set in the base class around [Line 139](https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L139).

The first time any port object is instantiated, this property is truthful in that it indicates whether `--root` was passed in on the command line.

However around [line 1135](https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L1135) there is a method called `_build_path` which, unfortunately, mutates the `options` dictionary.

If `_build_path` is called on *any* port instance, then any subsequently instantiated port instance will have `_root_was_set` be set to true.

In order to fix this, we need to understand why the `options` dictionary is being mutated to propagate this information and find a better way to do this.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151105/c4a9787f/attachment.html>


More information about the webkit-unassigned mailing list