<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859#c12">Comment # 12</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - run-webkit-test should look in --root directory for LayoutTestRelay"
href="https://bugs.webkit.org/show_bug.cgi?id=150859">bug 150859</a>
from <span class="vcard"><a class="email" href="mailto:jmarcell@apple.com" title="Jason Marcell <jmarcell@apple.com>"> <span class="fn">Jason Marcell</span></a>
</span></b>
<pre>The property `_root_was_set` gets set in the base class around [Line 139](<a href="https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L139">https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L139</a>).
The first time any port object is instantiated, this property is truthful in that it indicates whether `--root` was passed in on the command line.
However around [line 1135](<a href="https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L1135">https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/base.py#L1135</a>) there is a method called `_build_path` which, unfortunately, mutates the `options` dictionary.
If `_build_path` is called on *any* port instance, then any subsequently instantiated port instance will have `_root_was_set` be set to true.
In order to fix this, we need to understand why the `options` dictionary is being mutated to propagate this information and find a better way to do this.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>