[Webkit-unassigned] [Bug 150642] [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150642

--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 264798
  --> https://bugs.webkit.org/attachment.cgi?id=264798
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264798&action=review

Quite a complex patch... I didn't review the whole thing, just adding a couple of comments.

> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:43
> +        return GTK_STOCK_COPY;

Since GtkStock has been deprecated for several years now, you might take this opportunity to get rid of it.

GTK_STOCK_COPY would be replaced with "_Copy", for example.

See: https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-9KEGXpKy3-NEPpZZkUGJY/pub?output=html

I guess that could be a follow-up patch, though.

> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:150
> +void WebContextMenuItemGtk::createGtkActionIfNeeded()

How hard is it to add support for GAction as an alternative to GtkAction?  I wouldn't expect you to do that in this patch, but Arnaud and I are planning to drop use of GtkAction in Epiphany, so we need a GAction API here in order to keep our custom context menu items.

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:-96
> -    bool shouldShowInputMethodsMenu()

Eeep, this was broken for ages and nobody noticed? Anyway, I agree with removing it, but maybe you could do that in a separate patch and backport it to 2.10? It sucks to have broken context menu items.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151104/a4101133/attachment.html>