<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS"
href="https://bugs.webkit.org/show_bug.cgi?id=150642#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Use CROSS_PLATFORM_CONTEXT_MENUS"
href="https://bugs.webkit.org/show_bug.cgi?id=150642">bug 150642</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264798&action=diff" name="attach_264798" title="Patch">attachment 264798</a> <a href="attachment.cgi?id=264798&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264798&action=review">https://bugs.webkit.org/attachment.cgi?id=264798&action=review</a>
Quite a complex patch... I didn't review the whole thing, just adding a couple of comments.
<span class="quote">> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:43
> + return GTK_STOCK_COPY;</span >
Since GtkStock has been deprecated for several years now, you might take this opportunity to get rid of it.
GTK_STOCK_COPY would be replaced with "_Copy", for example.
See: <a href="https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-9KEGXpKy3-NEPpZZkUGJY/pub?output=html">https://docs.google.com/spreadsheets/d/1HavJQRPpMuq-N0GoN1wJR-9KEGXpKy3-NEPpZZkUGJY/pub?output=html</a>
I guess that could be a follow-up patch, though.
<span class="quote">> Source/WebKit2/Shared/gtk/WebContextMenuItemGtk.cpp:150
> +void WebContextMenuItemGtk::createGtkActionIfNeeded()</span >
How hard is it to add support for GAction as an alternative to GtkAction? I wouldn't expect you to do that in this patch, but Arnaud and I are planning to drop use of GtkAction in Epiphany, so we need a GAction API here in order to keep our custom context menu items.
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:-96
> - bool shouldShowInputMethodsMenu()</span >
Eeep, this was broken for ages and nobody noticed? Anyway, I agree with removing it, but maybe you could do that in a separate patch and backport it to 2.10? It sucks to have broken context menu items.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>