[Webkit-unassigned] [Bug 150772] [GLIB] Remove support for GSocket main loop sources from GMainLoopSource

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=150772

Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #264512|review?                     |review+
              Flags|                            |

--- Comment #2 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 264512
  --> https://bugs.webkit.org/attachment.cgi?id=264512
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=264512&action=review

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:33
> +#include <glib.h>
> +#include <wtf/Forward.h>
> +#include <wtf/Noncopyable.h>
> +#include <wtf/RunLoop.h>
> +#include <wtf/glib/GRefPtr.h>

Also include <functional>, for std::function<>.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:40
> +    WTF_MAKE_NONCOPYABLE(GSocketMonitor); WTF_MAKE_FAST_ALLOCATED;

No need for WTF_MAKE_FAST_ALLOCATED -- `new GSocketMonitor` is never called anyway.

> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:45
> +    void start(GSocket*, GIOCondition, RunLoop&, std::function<gboolean (GIOCondition)>);

Take in an rvalue reference to std::function<>. It doesn't change much in this case, but it's a good habit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20151102/f28d6fb6/attachment.html>