<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Remove support for GSocket main loop sources from GMainLoopSource"
href="https://bugs.webkit.org/show_bug.cgi?id=150772">bug 150772</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #264512 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Remove support for GSocket main loop sources from GMainLoopSource"
href="https://bugs.webkit.org/show_bug.cgi?id=150772#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GLIB] Remove support for GSocket main loop sources from GMainLoopSource"
href="https://bugs.webkit.org/show_bug.cgi?id=150772">bug 150772</a>
from <span class="vcard"><a class="email" href="mailto:zan@falconsigh.net" title="Zan Dobersek <zan@falconsigh.net>"> <span class="fn">Zan Dobersek</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=264512&action=diff" name="attach_264512" title="Patch">attachment 264512</a> <a href="attachment.cgi?id=264512&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=264512&action=review">https://bugs.webkit.org/attachment.cgi?id=264512&action=review</a>
<span class="quote">> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:33
> +#include <glib.h>
> +#include <wtf/Forward.h>
> +#include <wtf/Noncopyable.h>
> +#include <wtf/RunLoop.h>
> +#include <wtf/glib/GRefPtr.h></span >
Also include <functional>, for std::function<>.
<span class="quote">> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:40
> + WTF_MAKE_NONCOPYABLE(GSocketMonitor); WTF_MAKE_FAST_ALLOCATED;</span >
No need for WTF_MAKE_FAST_ALLOCATED -- `new GSocketMonitor` is never called anyway.
<span class="quote">> Source/WebKit2/Platform/IPC/glib/GSocketMonitor.h:45
> + void start(GSocket*, GIOCondition, RunLoop&, std::function<gboolean (GIOCondition)>);</span >
Take in an rvalue reference to std::function<>. It doesn't change much in this case, but it's a good habit.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>