[Webkit-unassigned] [Bug 137597] Support activation behavior of link element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137597

--- Comment #19 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 239699
  --> https://bugs.webkit.org/attachment.cgi?id=239699
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239699&action=review

> Source/WebCore/html/HTMLLinkElement.cpp:419
> +    frame->loader().urlSelected(url, target(), PassRefPtr<Event>(&event), LockHistory::No, LockBackForwardList::No, MaybeSendReferrer);

Creating a PassRefPtr from a reference does not make sense.

We should eliminate PassRefPtr<Event> from FrameLoader, and just use pointers. There isn't transfer of ownership, and the code is not performance sensitive in the first place.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150531/cbc18231/attachment-0001.html>