<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support activation behavior of link element"
href="https://bugs.webkit.org/show_bug.cgi?id=137597#c19">Comment # 19</a>
on <a class="bz_bug_link
bz_status_RESOLVED bz_closed"
title="RESOLVED FIXED - Support activation behavior of link element"
href="https://bugs.webkit.org/show_bug.cgi?id=137597">bug 137597</a>
from <span class="vcard"><a class="email" href="mailto:ap@webkit.org" title="Alexey Proskuryakov <ap@webkit.org>"> <span class="fn">Alexey Proskuryakov</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=239699&action=diff" name="attach_239699" title="Patch">attachment 239699</a> <a href="attachment.cgi?id=239699&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=239699&action=review">https://bugs.webkit.org/attachment.cgi?id=239699&action=review</a>
<span class="quote">> Source/WebCore/html/HTMLLinkElement.cpp:419
> + frame->loader().urlSelected(url, target(), PassRefPtr<Event>(&event), LockHistory::No, LockBackForwardList::No, MaybeSendReferrer);</span >
Creating a PassRefPtr from a reference does not make sense.
We should eliminate PassRefPtr<Event> from FrameLoader, and just use pointers. There isn't transfer of ownership, and the code is not performance sensitive in the first place.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>