[Webkit-unassigned] [Bug 137651] WeakMap reference w/ DOM element as key does not survive long enough

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137651

--- Comment #11 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 253904
  --> https://bugs.webkit.org/attachment.cgi?id=253904
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253904&action=review

> Source/WebCore/bindings/js/JSNodeCustom.cpp:79
> -static inline bool isObservable(JSNode* jsNode, Node* node)
> -{
> -    // The root node keeps the tree intact.
> -    if (!node->parentNode())
> -        return true;
> -
> -    if (jsNode->hasCustomProperties())
> -        return true;
> -
> -    // A node's JS wrapper is responsible for marking its JS event listeners.
> -    if (node->hasEventListeners())
> -        return true;
> -
> -    return false;
> -}
> -
> -static inline bool isReachableFromDOM(JSNode* jsNode, Node* node, SlotVisitor& visitor)
> +static inline bool isReachableFromDOM(Node* node, SlotVisitor& visitor)

Hmmm, it seems like we should do some performance tests to make sure that this isn't too severe.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150529/ba4be829/attachment.html>