<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - WeakMap reference w/ DOM element as key does not survive long enough"
href="https://bugs.webkit.org/show_bug.cgi?id=137651#c11">Comment # 11</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - WeakMap reference w/ DOM element as key does not survive long enough"
href="https://bugs.webkit.org/show_bug.cgi?id=137651">bug 137651</a>
from <span class="vcard"><a class="email" href="mailto:fpizlo@apple.com" title="Filip Pizlo <fpizlo@apple.com>"> <span class="fn">Filip Pizlo</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253904&action=diff" name="attach_253904" title="The patch">attachment 253904</a> <a href="attachment.cgi?id=253904&action=edit" title="The patch">[details]</a></span>
The patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253904&action=review">https://bugs.webkit.org/attachment.cgi?id=253904&action=review</a>
<span class="quote">> Source/WebCore/bindings/js/JSNodeCustom.cpp:79
> -static inline bool isObservable(JSNode* jsNode, Node* node)
> -{
> - // The root node keeps the tree intact.
> - if (!node->parentNode())
> - return true;
> -
> - if (jsNode->hasCustomProperties())
> - return true;
> -
> - // A node's JS wrapper is responsible for marking its JS event listeners.
> - if (node->hasEventListeners())
> - return true;
> -
> - return false;
> -}
> -
> -static inline bool isReachableFromDOM(JSNode* jsNode, Node* node, SlotVisitor& visitor)
> +static inline bool isReachableFromDOM(Node* node, SlotVisitor& visitor)</span >
Hmmm, it seems like we should do some performance tests to make sure that this isn't too severe.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>