[Webkit-unassigned] [Bug 93674] onchange is sent to <input type=radio> before onclick

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93674

Rohit <kumar.rohit at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253702|                            |review?
              Flags|                            |

--- Comment #15 from Rohit <kumar.rohit at samsung.com> ---
Comment on attachment 253702
  --> https://bugs.webkit.org/attachment.cgi?id=253702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253702&action=review

>> Source/WebCore/html/CheckboxInputType.cpp:86
>>      }
> 
> nit: No curly braces arouns a single line statement.

Done.

>> Source/WebCore/html/HTMLInputElement.cpp:862
>> +        setTextAsOfLastFormControlChangeEvent(String());
> 
> Why is this call to setTextAsOfLastFormControlChangeEvent necessary even we've already called it in HTMLInputElement::setChecked?
> It seems strange that we need to call it in both places.

Removed.
I added setTextAsOfLastFormControlChangeEvent(String()) in both as setChecked() and dispatchChangeEventIfNeeded() are getting called in if-else statements. But as setChecked() is already getting called in willDispatchClick for both radio and checkbox, it makes more sense to remove it from dispatchChangeEventIfNeeded().

>> Source/WebCore/html/RadioInputType.cpp:184
>>      }
> 
> nit: No curly braces around a single line statement.

Done.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150527/b2ad94d9/attachment-0001.html>