<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:kumar.rohit@samsung.com" title="Rohit <kumar.rohit@samsung.com>"> <span class="fn">Rohit</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - onchange is sent to <input type=radio> before onclick"
href="https://bugs.webkit.org/show_bug.cgi?id=93674">bug 93674</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253702 Flags</td>
<td>
</td>
<td>review?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - onchange is sent to <input type=radio> before onclick"
href="https://bugs.webkit.org/show_bug.cgi?id=93674#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - onchange is sent to <input type=radio> before onclick"
href="https://bugs.webkit.org/show_bug.cgi?id=93674">bug 93674</a>
from <span class="vcard"><a class="email" href="mailto:kumar.rohit@samsung.com" title="Rohit <kumar.rohit@samsung.com>"> <span class="fn">Rohit</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=253702&action=diff" name="attach_253702" title="Patch">attachment 253702</a> <a href="attachment.cgi?id=253702&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253702&action=review">https://bugs.webkit.org/attachment.cgi?id=253702&action=review</a>
<span class="quote">>> Source/WebCore/html/CheckboxInputType.cpp:86
>> }
>
> nit: No curly braces arouns a single line statement.</span >
Done.
<span class="quote">>> Source/WebCore/html/HTMLInputElement.cpp:862
>> + setTextAsOfLastFormControlChangeEvent(String());
>
> Why is this call to setTextAsOfLastFormControlChangeEvent necessary even we've already called it in HTMLInputElement::setChecked?
> It seems strange that we need to call it in both places.</span >
Removed.
I added setTextAsOfLastFormControlChangeEvent(String()) in both as setChecked() and dispatchChangeEventIfNeeded() are getting called in if-else statements. But as setChecked() is already getting called in willDispatchClick for both radio and checkbox, it makes more sense to remove it from dispatchChangeEventIfNeeded().
<span class="quote">>> Source/WebCore/html/RadioInputType.cpp:184
>> }
>
> nit: No curly braces around a single line statement.</span >
Done.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>