[Webkit-unassigned] [Bug 93674] onchange is sent to <input type=radio> before onclick

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=93674

--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 253702
  --> https://bugs.webkit.org/attachment.cgi?id=253702
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253702&action=review

> Source/WebCore/html/CheckboxInputType.cpp:86
> +    } else {
> +        element().dispatchChangeEventIfNeeded(); 
>      }

nit: No curly braces arouns a single line statement.

> Source/WebCore/html/HTMLInputElement.cpp:862
> +        setTextAsOfLastFormControlChangeEvent(String());

Why is this call to setTextAsOfLastFormControlChangeEvent necessary even we've already called it in HTMLInputElement::setChecked?
It seems strange that we need to call it in both places.

> Source/WebCore/html/RadioInputType.cpp:184
> +    } else {
> +        element().dispatchChangeEventIfNeeded();
>      }

nit: No curly braces around a single line statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150526/533b2d35/attachment.html>