<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - onchange is sent to <input type=radio> before onclick"
href="https://bugs.webkit.org/show_bug.cgi?id=93674#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - onchange is sent to <input type=radio> before onclick"
href="https://bugs.webkit.org/show_bug.cgi?id=93674">bug 93674</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253702&action=diff" name="attach_253702" title="Patch">attachment 253702</a> <a href="attachment.cgi?id=253702&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253702&action=review">https://bugs.webkit.org/attachment.cgi?id=253702&action=review</a>
<span class="quote">> Source/WebCore/html/CheckboxInputType.cpp:86
> + } else {
> + element().dispatchChangeEventIfNeeded();
> }</span >
nit: No curly braces arouns a single line statement.
<span class="quote">> Source/WebCore/html/HTMLInputElement.cpp:862
> + setTextAsOfLastFormControlChangeEvent(String());</span >
Why is this call to setTextAsOfLastFormControlChangeEvent necessary even we've already called it in HTMLInputElement::setChecked?
It seems strange that we need to call it in both places.
<span class="quote">> Source/WebCore/html/RadioInputType.cpp:184
> + } else {
> + element().dispatchChangeEventIfNeeded();
> }</span >
nit: No curly braces around a single line statement.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>