[Webkit-unassigned] [Bug 144380] [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144380

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #253310|review?                     |review+
              Flags|                            |

--- Comment #13 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 253310
  --> https://bugs.webkit.org/attachment.cgi?id=253310
Try to fix IOS build

View in context: https://bugs.webkit.org/attachment.cgi?id=253310&action=review

> Source/WebKit2/Platform/SharedMemory.h:88
> +    static RefPtr<SharedMemory> wrapMap(void*, size_t, int fileDescriptor);

This should be #if'd for the platforms it is implemented only.

> Source/WebKit2/Shared/ShareableResource.cpp:85
> +PassRefPtr<SharedBuffer> ShareableResource::sharedBuffer()
> +{
> +    ref(); // Balanced by deref when SharedBuffer is deallocated.

This is named like an accessor but does some non-accessor like ref tricks. Maybe wrapInSharedBuffer()?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150519/344efcb4/attachment-0001.html>