<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform"
href="https://bugs.webkit.org/show_bug.cgi?id=144380">bug 144380</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #253310 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform"
href="https://bugs.webkit.org/show_bug.cgi?id=144380#c13">Comment # 13</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] Network Cache: Implement ShareableResource for Soup and enable it for GTK platform"
href="https://bugs.webkit.org/show_bug.cgi?id=144380">bug 144380</a>
from <span class="vcard"><a class="email" href="mailto:koivisto@iki.fi" title="Antti Koivisto <koivisto@iki.fi>"> <span class="fn">Antti Koivisto</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=253310&action=diff" name="attach_253310" title="Try to fix IOS build">attachment 253310</a> <a href="attachment.cgi?id=253310&action=edit" title="Try to fix IOS build">[details]</a></span>
Try to fix IOS build
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253310&action=review">https://bugs.webkit.org/attachment.cgi?id=253310&action=review</a>
<span class="quote">> Source/WebKit2/Platform/SharedMemory.h:88
> + static RefPtr<SharedMemory> wrapMap(void*, size_t, int fileDescriptor);</span >
This should be #if'd for the platforms it is implemented only.
<span class="quote">> Source/WebKit2/Shared/ShareableResource.cpp:85
> +PassRefPtr<SharedBuffer> ShareableResource::sharedBuffer()
> +{
> + ref(); // Balanced by deref when SharedBuffer is deallocated.</span >
This is named like an accessor but does some non-accessor like ref tricks. Maybe wrapInSharedBuffer()?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>