[Webkit-unassigned] [Bug 144954] Small refactoring before ES6 Arrow function implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144954

--- Comment #15 from GSkachkov <gskachkov at gmail.com> ---
Comment on attachment 253059
  --> https://bugs.webkit.org/attachment.cgi?id=253059
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253059&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:1314
>>  {
> 
> It's also weird that we we're returning bools and ints from this function.
> I think there is probably some case that isn't being thought through.

I'm quite new in webkit, so I tried to follow exist examples. Could you please suggest what I should change in this function?

>> Source/JavaScriptCore/parser/Parser.cpp:1363
>> +    int parametersStart = parseFunctionParamters(context, requirements, mode, nameIsInContainingScope, functionScope, info);
> 
> You might need to propagate errors here.

Done in new patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150514/2cfffd93/attachment-0001.html>