<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Small refactoring before ES6 Arrow function implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=144954#c15">Comment # 15</a>
on <a class="bz_bug_link
bz_status_REOPENED "
title="REOPENED - Small refactoring before ES6 Arrow function implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=144954">bug 144954</a>
from <span class="vcard"><a class="email" href="mailto:gskachkov@gmail.com" title="GSkachkov <gskachkov@gmail.com>"> <span class="fn">GSkachkov</span></a>
</span></b>
<pre>Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=253059&action=diff" name="attach_253059" title="Patch">attachment 253059</a> <a href="attachment.cgi?id=253059&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=253059&action=review">https://bugs.webkit.org/attachment.cgi?id=253059&action=review</a>
<span class="quote">>> Source/JavaScriptCore/parser/Parser.cpp:1314
>> {
>
> It's also weird that we we're returning bools and ints from this function.
> I think there is probably some case that isn't being thought through.</span >
I'm quite new in webkit, so I tried to follow exist examples. Could you please suggest what I should change in this function?
<span class="quote">>> Source/JavaScriptCore/parser/Parser.cpp:1363
>> + int parametersStart = parseFunctionParamters(context, requirements, mode, nameIsInContainingScope, functionScope, info);
>
> You might need to propagate errors here.</span >
Done in new patch</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>