[Webkit-unassigned] [Bug 144770] Media Controls stop update after hovering for a few seconds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=144770

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #252641|review?                     |review+
              Flags|                            |

--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 252641
  --> https://bugs.webkit.org/attachment.cgi?id=252641
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=252641&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:288
> +        // When unhiding the controls, the offsetWidth and offsetHeight are briefly 0.
> +        // This causes the timeline to not update properly.
> +        // Make sure we retain our old timeline metrics state if this is the case.
> +        if (this.timelineMetricsNeedsUpdate && this.controls.timeline.offsetWidth && this.controls.timeline.offsetHeight) {

This is not a great strategy. We need to do the update when we know it is correct to do it. It seems possible that a value of 0 is not the only kind of incorrect value we might see if we look at the wrong time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150510/e96bff93/attachment.html>