<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770">bug 144770</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #252641 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770#c10">Comment # 10</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Media Controls stop update after hovering for a few seconds"
href="https://bugs.webkit.org/show_bug.cgi?id=144770">bug 144770</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=252641&action=diff" name="attach_252641" title="patch">attachment 252641</a> <a href="attachment.cgi?id=252641&action=edit" title="patch">[details]</a></span>
patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=252641&action=review">https://bugs.webkit.org/attachment.cgi?id=252641&action=review</a>
<span class="quote">> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:288
> + // When unhiding the controls, the offsetWidth and offsetHeight are briefly 0.
> + // This causes the timeline to not update properly.
> + // Make sure we retain our old timeline metrics state if this is the case.
> + if (this.timelineMetricsNeedsUpdate && this.controls.timeline.offsetWidth && this.controls.timeline.offsetHeight) {</span >
This is not a great strategy. We need to do the update when we know it is correct to do it. It seems possible that a value of 0 is not the only kind of incorrect value we might see if we look at the wrong time.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>